BUG: Fix RecursionError when apply native container types as a func #61615
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 16, 2025
| @@ -1298,7 +1299,7 @@ cdef bint c_is_list_like(object obj, bint allow_sets) except -1: | |||
| getattr(obj, "__iter__", None) is not None and not isinstance(obj, type) | |||
| # we do not count strings/unicode/bytes as list-like | |||
| # exclude Generic types that have __iter__ | |||
| and not isinstance(obj, (str, bytes, _GenericAlias)) | |||
| and not isinstance(obj, (str, bytes, _GenericAlias, GenericAlias)) | |||
There was a problem hiding this comment.
Do we need _GenericAlias and GenericAlias?
There was a problem hiding this comment.
Yes.
Container classes in typing can be tested with typing._GenericAlias.
But, native container types can be tested with types.GenericAlias.
It is independent of each other.
I tested it. It was as follows:
import typing
import types
print(isinstance(typing.List[int], typing._GenericAlias)) # True
print(isinstance(typing.List[int], types.GenericAlias)) # False
print(isinstance( list[int], typing._GenericAlias)) # False
print(isinstance( list[int], types.GenericAlias)) # TrueSo, it is necessary to add types.GenericAlias to do # exclude Generic types that have __iter__ properly.
mroeschke
approved these changes
Jun 16, 2025
|
Thanks @heoh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Description
Fixes a bug in
DataFrame.applyraisingRecursionErrorwhen passingfunc=list[int].Cause
The existing code handled parameterized container types, but not native container types, yielding false positives. I also added a check for
types.GenericAliasto handle native container types.Reference: https://github.com/python/cpython/blob/3.12/Lib/typing.py#L1251